Inspectapedia has a vinyl siding guide that said the siding should stop 1/2 inch minimum distance above the shingles to prevent damage to the siding.

Should siding touch roof?

Best practice is to keep the siding material two inches above the roof. Most people settle for a one-inch clearance. There are step flashings under the siding and roof, so it's okay to keep the siding above the roof surface.

Do shingles go on before siding?

roofing goes before windows go in or siding. right after the framing crew puts on the trim.