It's usually not a problem for the lawyer who drew up a will to also serve as a witness when the will is signed, even if he or she is named as the executor and will profit later from charging fees for the executor's work.
Does the executor of a will need to sign it?
Unlike appointing an attorney for an Enduring Power of Attorney or a Substitute Decision Maker under an Advance Care Directive (where those you appoint need to sign the document agreeing to act), an executor does not need to sign your Will. Indeed, no-one has to act as your executor if they do not want to.
Who has to sign a will?
Who can witness a will? Anyone 18 years and over can witness or sign a will, but importantly, a beneficiary can't witness a will, and neither can their spouse or civil partner. In many cases, people will ask a friend or work colleague to sign and witness the will.